Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send deployment id and minio version in http header #14378

Merged
merged 2 commits into from Feb 23, 2022

Conversation

anjalshireesh
Copy link
Contributor

Description

Send deployment id and minio version in the http headers
x-minio-version and x-minio-deployment-id respectively.

Motivation and Context

Going forward, these can be used by the webhook targets to

  • uniquely identify the cluster
  • use the minio version to understand the payload format (in cases where the format has changed between versions)

How to test this PR?

  • Configure a logger webhook (where you can inspect headers of the webhook payload e.g. https://webhook.site/)
  • Simulate an event in the cluster that triggers the webhook call
  • Verify that the webhook request contains the two new headers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

internal/http/server.go Outdated Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana
Copy link
Member

ptal @donatello

@harshavardhana harshavardhana requested review from krisis and removed request for donatello February 23, 2022 19:57
@harshavardhana harshavardhana merged commit 25144fe into minio:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants