fix: openid config provider not initialized correctly #14399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now `InitializeProvider` method of `Config` struct was implemented on a value receiver which is why changes on `provider` field where never reflected to method callers. In order to fix this issue, the method was implemented on a pointer receiver.
harshavardhana
approved these changes
Feb 24, 2022
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until now
InitializeProvidermethod ofConfigstruct wasimplemented on a value receiver which is why changes on
providerfield where never reflected to method callers. In order to fix this
issue, the method was implemented on a pointer receiver.
Motivation and Context
Keycloak IDP user removal job was never triggered because of wrong configuration initialization.
How to test this PR?
Unit test was implemented in
internal/config/identity/openid/jwt_test.goTypes of changes
Checklist:
commit-idorPR #here)