fix: regression from refactor in AMQP notification #14455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a regression introduced in minio#14269 that refactored the notification registration logic, all the amqp targets however online will not be available for use anymore. fixes minio#14451
anjalshireesh
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: regression from refactor in AMQP notification
Motivation and Context
fixes a regression introduced in #14269 that refactored
the notification registration logic, all the AMQP targets
however online will not be available for use anymore.
fixes #14451
How to test this PR?
As per #14451
Types of changes
Checklist:
config set#14269