Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heal: Enable periodic bitrot scan configuration #14464

Merged
merged 2 commits into from Apr 7, 2022

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Mar 3, 2022

Description

bitrotscan parameter in heal config supports new value as the deep heal scan cycle for the scanner
mc admin config set play heal bitrotscan=off - never run the bitrot heal during the scan
mc admin config set play heal bitrotscan=on - always run the bitrot heal during the scan
mc admin config set play heal bitrotscan=30d - run the bitrot heal each 30 days

Other functional changes:

  • No bitrot scan during healing using MRF - recent files do not need bitrot scan
  • No bitrot scan during disks replacement - faster new disk healing

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

cmd/data-scanner.go Outdated Show resolved Hide resolved
@klauspost
Copy link
Contributor

Waiting for updates. Ping me when ready.

@vadmeste
Copy link
Member Author

vadmeste commented Mar 10, 2022

Waiting for updates. Ping me when ready.

@klauspost, done

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change

internal/config/heal/heal.go Outdated Show resolved Hide resolved
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - otherwise LGTM

cmd/storage-rest-server.go Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-gateway-nas.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 16431d2 into minio:master Apr 7, 2022
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Apr 9, 2022
kannappanr pushed a commit that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants