Optionally run a command when completing jobs #15017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to run a command before the jobs (e.g. make bucket job) are completed.
Motivation and Context
In our case we are using istio, a sidecar container is injected and we cannot contact minio without this. The problem is it does not terminate once the main container is completed. This change will allow us to add a curl command to stop the istio container, when the main command is finished so kubernetes can complete the job.
How to test this PR?
Add in a command to
exitCommand
, view logs and ensure you can see it has run.Types of changes
Checklist:
commit-id
orPR #
here)