Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in site replication version healing #15103

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jun 17, 2022

Description

Motivation and Context


API: SYSTEM()
Time: 20:25:51 UTC 06/17/2022
DeploymentID: f49f4812-09e6-41ee-923d-cc7c8aa3f563
Error: Error healing sse metadata from peer site local2 : expected element type <ServerSideEncryptionConfiguration> but have <VersioningConfiguration> (*fmt.wrapError)
       4: internal/logger/logger.go:278:logger.LogIf()
       3: cmd/site-replication.go:3716:cmd.(*SiteReplicationSys).healVersioningMetadata()
       2: cmd/site-replication.go:3446:cmd.(*SiteReplicationSys).healBuckets()
       1: cmd/site-replication.go:3381:cmd.(*SiteReplicationSys).startHealRoutine()

How to test this PR?

Perrform site replication from cluster with existing versioned buckets - site heal will be triggered and should not log above error

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@poornas poornas requested a review from kannappanr June 17, 2022 21:21
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 8b9a19e into minio:master Jun 17, 2022
@harshavardhana harshavardhana deleted the fxsitehealing branch June 17, 2022 23:43
@bh4t bh4t added the bugfix label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants