Better reporting of total/free usable capacity of the cluster #15230
+39
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code uses approximation using a ratio. The approximation can skrew if we have multiple pools with different disk capacity. Replace the algorithm with a simpler one which counts data disks and ignore parity disks.
vadmeste
force-pushed
the
fix-available-space
branch
from
92b7e4c
to
9ad7b30
Compare
harshavardhana
requested changes
Jul 5, 2022
vadmeste
force-pushed
the
fix-available-space
branch
from
ab70d20
to
cb6c907
Compare
harshavardhana
requested changes
Jul 6, 2022
harshavardhana
approved these changes
Jul 6, 2022
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current code uses approximation using a ratio. The approximation can
skew if we have multiple pools with different disk capacity.
Replace the algorithm with a simpler one which counts data disks and
ignore parity disks.
Motivation and Context
Better reporting for usable/free capacity
How to test this PR?
Get prometheus data starts with 'minio_cluster_capacity'
Types of changes
Checklist:
commit-idorPR #here)