kms: add context.Context to KMS API calls
#15327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `context.Context` to the
the KMS `{Stat, CreateKey, GenerateKey}` API
calls.
The context will be used to terminate external calls
as soon as the client requests gets canceled.
A follow-up PR will add a `context.Context` to
the remaining `DecryptKey` API call.
Signed-off-by: Andreas Auernhammer <hi@aead.dev>
Mint Automation
|
aead
added a commit
to aead/minio
that referenced
this pull request
Jul 18, 2022
This commit adds adds a `context.Context` to the KMS `DecryptKey` API calls. The context will be used to terminate external calls as soon as the client requests gets canceled. Follow up of minio#15327 Signed-off-by: Andreas Auernhammer <hi@aead.dev>
7 tasks
harshavardhana
approved these changes
Jul 18, 2022
poornas
approved these changes
Jul 18, 2022
aead
added a commit
to aead/minio
that referenced
this pull request
Jul 22, 2022
This commit adds adds a `context.Context` to the KMS `DecryptKey` API calls. The context will be used to terminate external calls as soon as the client requests gets canceled. Follow up of minio#15327 Signed-off-by: Andreas Auernhammer <hi@aead.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a
context.Contextto thethe KMS
{Stat, CreateKey, GenerateKey}APIcalls.
The context will be used to terminate external calls
as soon as the client requests gets canceled.
A follow-up PR will add a
context.Contexttothe remaining
DecryptKeyAPI call.Motivation and Context
KMS
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)