Independent Multipart Uploads #15346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do completely independent multipart uploads. First split into separate file
klauspost
force-pushed
the
multipart-indep-upload
branch
from
d475a95
to
e7a36a8
Compare
Mint Automation
|
harshavardhana
approved these changes
Jul 19, 2022
| @@ -229,7 +229,10 @@ func (client *storageRESTClient) NSScanner(ctx context.Context, cache dataUsageC | |||
| rr.CloseWithError(err) | |||
| return cache, err | |||
| } | |||
| updates <- update | |||
| select { | |||
| case <-ctx.Done(): | |||
There was a problem hiding this comment.
Forgot to add a return here @klauspost
poornas
added a commit
to poornas/minio
that referenced
this pull request
Nov 26, 2022
Fixes regression from PR's minio#15674, minio#15929, minio#13171 and minio#15346
poornas
added a commit
to poornas/minio
that referenced
this pull request
Nov 26, 2022
Fixes regression from PR's minio#15674, minio#15929, minio#13171 and minio#15346
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
In distributed mode a lock was held to merge each multipart upload as it was added.
This lock was highly contested and retries are expensive (timewise) in distributed mode.
Instead each part adds its metadata information uniquely. This eliminates the per object lock required for each to merge.
The metadata is read back and merged by "CompleteMultipartUpload" without locks when constructing final object.
Worst case benchmark; 4000 parts uploaded in parallel - each part-size 10MiB, concurrency of 160:
(covers upload phase)
ListObjectParts will also need to merge part data on each call, which will make it slower, but this is by far less used than Multipart uploads, so this tradeoff makes sense.
Technically multipart uploads should be retainable across an upgrade, but stopping them would by far be the safest.
How to test this PR?
Plenty of tests cover this already.
Types of changes