use partInfo only for intermediate part.x.meta #15353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
improve-multipart
branch
from
5be0592
to
0f9c470
Compare
harshavardhana
force-pushed
the
improve-multipart
branch
from
0f9c470
to
92cbebd
Compare
poornas
approved these changes
Jul 19, 2022
Mint Automation
|
krisis
approved these changes
Jul 20, 2022
|
Not really sure what the modtime is used for, but LGTM 👍🏼 |
ModTime is used in ListObjectParts() @klauspost :-) we never had it properly working from Day 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use partInfo only for intermediate part.x.meta
Motivation and Context
simplify the additional metadata by saving little
How to test this PR?
manually, tests cover it.
Types of changes
Checklist:
commit-idorPR #here)