Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DelKVS to delete specific sub-system fields. #15354

Merged
merged 7 commits into from
Jul 22, 2022

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Jul 19, 2022

Description

This allows DelKVS to reset specific fields within a sub-system to their default values, or delete the field if there is no default value

Motivation and Context

This allows for greater control of config sub-systems when resetting. Currently, the entire sub-system is deleted, then reset to default on server restart. This adds the ability to reset a field without resetting the whole sub-system.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

Can reset specific variables in a config subsystem back to default/ delete them if there is no default value
cmd/admin-handlers-idp-config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - however could you rebase the commits and squash them into a single one with an appropriate commit message?

@harshavardhana harshavardhana merged commit e839303 into minio:master Jul 22, 2022
@taran-p taran-p deleted the config-reset branch July 22, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants