Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary logs in IAM store #15356

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

harshavardhana
Copy link
Member

Description

remove unnecessary logs in IAM store

Motivation and Context

remove spurious logs that have a proper
client response.

How to test this PR?

Nothing special doesn't change any
functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-pools.sh ✔️
mint-compress-encrypt-dist-erasure.sh more...

15356-f277e7e/mint-compress-encrypt-dist-erasure.sh.log:

Running with
SERVER_ENDPOINT:      minio-k8s3:32294
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0
RUN_ON_FAIL:          0

To get logs, run 'docker cp :/mint/log /tmp/mint-logs'

(1/14) Running awscli tests ... done in 59 seconds
(2/14) Running aws-sdk-go tests ... done in 1 seconds
(3/14) Running aws-sdk-java tests ... done in 1 seconds
(4/14) Running aws-sdk-php tests ... done in 44 seconds
(5/14) Running aws-sdk-ruby tests ... done in 7 seconds
(6/14) Running healthcheck tests ... done in 0 seconds
(7/14) Running mc tests ... done in 29 seconds
(8/14) Running minio-go tests ... done in 1 minutes and 8 seconds
(9/14) Running minio-java tests ... done in 31 seconds
(10/14) Running minio-js tests ... done in 1 minutes and 5 seconds
(11/14) Running minio-py tests ... done in 1 minutes and 19 seconds
(12/14) Running s3cmd tests ... FAILED in 1 minutes and 29 seconds
{
  "name": "s3cmd",
  "duration": "77003",
  "function": "test_sync_list_objects",
  "status": "FAIL",
  "error": "\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n    An unexpected error has occurred.\n  Please try reproducing the error using\n  the latest s3cmd code from the git master\n  branch found at:\n    https://github.com/s3tools/s3cmd\n  and have a look at the known issues list:\n    https://github.com/s3tools/s3cmd/wiki/Common-known-issues-and-their-solutions-(FAQ)\n  If the error persists, please report the\n  following lines (removing any private\n  info as necessary) to:\n   s3tools-bugs@lists.sourceforge.net\n\n\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n\nInvoked as: /usr/local/bin/s3cmd --config /tmp/.s3cmd-31544/s3cfg sync /mint/data/ s3://s3cmd-test-bucket-24776\nProblem: <class 'ConnectionRefusedError: [Errno 111] Connection refused\nS3cmd:   2.2.0\npython:   3.8.10 (default, Mar 15 2022, 12:22:08) \n[GCC 9.4.0]\nenvironment LANG=C.UTF-8\n\nTraceback (most recent call last):\n  File \"/usr/local/bin/s3cmd\", line 3209, in <module>\n    rc = main()\n  File \"/usr/local/bin/s3cmd\", line 3106, in main\n    rc = cmd_func(args)\n  File \"/usr/local/bin/s3cmd\", line 1965, in cmd_sync\n    return cmd_sync_local2remote(args)\n  File \"/usr/local/bin/s3cmd\", line 1932, in cmd_sync_local2remote\n    ret = _single_process(args[:-1])\n  File \"/usr/local/bin/s3cmd\", line 1682, in _single_process\n    return _child(destination_base, source_args)\n  File \"/usr/local/bin/s3cmd\", line 1791, in _child\n    remote_list, dst_exclude_list, remote_total_size = fetch_remote_list(destbase_with_source_list, recursive = True, require_attribs = True)\n  File \"/usr/local/lib/python3.8/dist-packages/S3/FileLists.py\", line 470, in fetch_remote_list\n    objectlist, tmp_total_size = _get_filelist_remote(uri, recursive = True)\n  File \"/usr/local/lib/python3.8/dist-packages/S3/FileLists.py\", line 406, in _get_filelist_remote\n    response = s3.bucket_list(remote_uri.bucket(), prefix = remote_uri.object(),\n  File \"/usr/local/lib/python3.8/dist-packages/S3/S3.py\", line 333, in bucket_list\n    for truncated, dirs, objects in self.bucket_list_streaming(bucket, prefix, recursive, uri_params, limit):\n  File \"/usr/local/lib/python3.8/dist-packages/S3/S3.py\", line 367, in bucket_list_streaming\n    response = self.bucket_list_noparse(bucket, prefix, recursive,\n  File \"/usr/local/lib/python3.8/dist-packages/S3/S3.py\", line 405, in bucket_list_noparse\n    response = self.send_request(request)\n  File \"/usr/local/lib/python3.8/dist-packages/S3/S3.py\", line 1480, in send_request\n    conn = ConnMan.get(self.get_hostname(resource['bucket']))\n  File \"/usr/local/lib/python3.8/dist-packages/S3/ConnMan.py\", line 284, in get\n    conn.c.connect()\n  File \"/usr/lib/python3.8/http/client.py\", line 922, in connect\n    self.sock = self._create_connection(\n  File \"/usr/lib/python3.8/socket.py\", line 808, in create_connection\n    raise err\n  File \"/usr/lib/python3.8/socket.py\", line 796, in create_connection\n    sock.connect(sa)\nConnectionRefusedError: [Errno 111] Connection refused\n\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n    An unexpected error has occurred.\n  Please try reproducing the error using\n  the latest s3cmd code from the git master\n  branch found at:\n    https://github.com/s3tools/s3cmd\n  and have a look at the known issues list:\n    https://github.com/s3tools/s3cmd/wiki/Common-known-issues-and-their-solutions-(FAQ)\n  If the error persists, please report the\n  above lines (removing any private\n  info as necessary) to:\n   s3tools-bugs@lists.sourceforge.net\n!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
}
(12/14) Running s3select tests ... done in 4 seconds
(13/14) Running versioning tests ... done in 3 minutes and 4 seconds

Executed 13 out of 14 tests successfully.

Deleting image on docker hub
Deleting image locally

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit d3f89fa into minio:master Jul 20, 2022
@harshavardhana harshavardhana deleted the remove-unnecessary-logs branch July 20, 2022 15:19
@bh4t bh4t added the bugfix label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants