-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add context cancelation #15374
Merged
harshavardhana
merged 2 commits into
minio:master
from
klauspost:tests-add-context-cancel
Jul 21, 2022
Merged
tests: Add context cancelation #15374
harshavardhana
merged 2 commits into
minio:master
from
klauspost:tests-add-context-cancel
Jul 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A huge number of goroutines would build up from various monitors When creating test filesystems provide a context so they can shut down when no longer needed.
Mint Automation
|
harshavardhana
approved these changes
Jul 21, 2022
harshavardhana
pushed a commit
that referenced
this pull request
Jul 21, 2022
This reverts commit 1e332f0. Reverting this as tests are failing randomly.
Reverted this since all tests are failing randomly across all PRs after this change
Perhaps an investigation is needed. |
@harshavardhana Do you have any information? I see master built fine after merge, so no idea what you are talking about. |
Seems like tests are just failing anyways. |
No not really this silent failure
|
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Oct 14, 2022
This reverts commit 564a0af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A huge number of goroutines would build up from various monitors
When creating test filesystems provide a context so they can shut down when no longer needed.
How to test this PR?
Tests only.
Types of changes