Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support additional claim info in Auditing STS calls #15381

Merged
merged 1 commit into from Jul 22, 2022
Merged

support additional claim info in Auditing STS calls #15381

merged 1 commit into from Jul 22, 2022

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jul 22, 2022 •
edited

Description

support additional claim info in Auditing STS calls

Motivation and Context

Adds a missing AuditLog from AssumeRoleWithCertificate API

Fixes #9529

How to test this PR?

~ MINIO_AUDIT_WEBHOOK_ENABLE_target1=on MINIO_AUDIT_WEBHOOK_ENDPOINT_target1=https://webhook.site/2db8d155-4ebc-4401-a808-bb65d360c8ba minio server ~/test &
~ cd docs/sts/; go run assume-role.go -u minioadmin -p minioadmin

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@harshavardhana harshavardhana changed the title support additional claim info in STS calls support additional claim info in Auditing STS calls Jul 22, 2022
@harshavardhana @minio-trusted
support additional claim info in STS calls
7b2b0c1 
Adds a missing AuditLog from AssumeRoleWithCertificate API

Fixes minio#9529
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

dvaldivia
dvaldivia approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested.lgtm

@harshavardhana harshavardhana merged commit b0d70a0 into minio:master Jul 22, 2022
@harshavardhana harshavardhana deleted the audit-sts branch July 22, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alevsk Alevsk Alevsk approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@donatello donatello Awaiting requested review from donatello

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Log should include Access Token created for AssumeRoleWith* requests
5 participants
@harshavardhana @minio-trusted @Alevsk @dvaldivia @bh4t