Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtimeClassName support to vanilla helm chart #15385

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Jul 22, 2022

Description

The PR adds runtimeClassName support to vanilla helm chart.

Motivation and Context

The PR closes #15217 issue and related to #14854 discussion.

How to test this PR?

helm template test . --debug
# There is no runtimeClassName in the output
helm template test . --set runtimeClassName=qwerty --debug
# There is runtimeClassName in the output
# ...
# spec:
#   runtimeClassName: "qwerty"
# ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add runtimeClassName support to helm chart
4 participants