Remove internal usage of consoleAdmin #15402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"consoleAdmin" was used as the policy for root derived accounts, but this lead to unexpected bugs when an administrator modified the consoleAdmin policy This change avoids evaluating a policy for root derived accounts as by default no policy is mapped to the root user. If a session policy is attached to a root derived account, it will be evaluated as expected.
donatello
force-pushed
the
internal-admin
branch
from
2fd349f
to
23c1888
Compare
Mint Automation
|
harshavardhana
approved these changes
Jul 27, 2022
harshavardhana
added a commit
to harshavardhana/minio
that referenced
this pull request
Jul 30, 2022
fixes minio#15436 This fixes a regression caused after the removal of "consoleAdmin" policy usage for 'root users' in PR minio#15402
7 tasks
harshavardhana
added a commit
that referenced
this pull request
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"consoleAdmin" was used as the policy for root derived accounts, but this
lead to unexpected bugs when an administrator modified the consoleAdmin
policy
This change avoids evaluating a policy for root derived accounts as by
default no policy is mapped to the root user. If a session policy is
attached to a root derived account, it will be evaluated as expected.
Motivation and Context
Avoid subtle bugs due to internal usage of user modifiable policies.
How to test this PR?
Modify the
consoleAdminpolicy and check if root STS/service accounts work as expected.Types of changes
Checklist:
commit-idorPR #here)