Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download binary once and push it to other servers #15407

Merged
merged 1 commit into from Jul 29, 2022
Merged

Download binary once and push it to other servers #15407

merged 1 commit into from Jul 29, 2022

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Jul 26, 2022 •
edited

Description

To reduce network traffic by downloading binary once and then pushing the downloaded binary to other servers.

Motivation and Context

To reduce network traffic to https://dl.min.io/server/minio/release/ specially when we have many MinIO Servers running together in a cluster.

How to test this PR?

Have MinIO Servers in distributed mode, then via mc command update servers:

mc alias set myminio http://192.168.0.13:9000 minio minio123
mc admin update myminio

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

@cniackz cniackz added the wip work in progress label Jul 26, 2022
@cniackz cniackz self-assigned this Jul 26, 2022
@cniackz cniackz marked this pull request as draft July 26, 2022 17:58
@cniackz cniackz removed the wip work in progress label Jul 27, 2022
@cniackz cniackz changed the title [WIP] - testing Download binary once and push it to other servers Jul 27, 2022
@cniackz cniackz marked this pull request as ready for review July 27, 2022 15:53
@minio minio deleted a comment from minio-trusted Jul 27, 2022
@harshavardhana
Copy link
Member

PTAL @vadmeste need your inputs here.

harshavardhana
harshavardhana requested changes Jul 28, 2022
View reviewed changes
cmd/admin-handlers.go Outdated Show resolved Hide resolved
cmd/peer-rest-client.go Outdated Show resolved Hide resolved
Alevsk
Alevsk reviewed Jul 28, 2022
View reviewed changes
cmd/admin-handlers.go Outdated Show resolved Hide resolved
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

klauspost
klauspost approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 8ec888d into minio:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@Alevsk Alevsk Awaiting requested review from Alevsk

Assignees

@cniackz cniackz

Labels
performance/optimize
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cniackz @harshavardhana @minio-trusted @Alevsk @klauspost @bh4t