do not allow filesystem fallback in server download #15429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for anyone with admin access to relatively to get any content of any random OS location by simply providing the file with 'mc admin update alias/ /etc/passwd`. Workaround is to disable 'admin:ServiceUpdate' action. Everyone is advised to upgrade to this patch. Thanks to @Alevsk for finding this bug.
Alevsk
approved these changes
Jul 29, 2022
Mint Automation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not allow filesystem fallback in server download
Motivation and Context
It is possible for anyone with admin access to relatively
to get any content of any random OS location by simply
providing the file with 'mc admin update alias/ /etc/passwd`.
A workaround is to disable 'admin:ServiceUpdate' action. Everyone
is advised to upgrade to this patch.
Thanks to @Alevsk for finding this bug.
How to test this PR?
Perform
mc admin update alias/ /etc/passwdyou will see '/etc/passwd' in the error response.Types of changes
Checklist:
commit-idorPR #here)