Add extended checksum #15433
Merged
Add extended checksum #15433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
force-pushed
the
add-extended-checksum
branch
from
04ce065
to
4617507
Compare
klauspost
commented
Jul 29, 2022
klauspost
commented
Jul 29, 2022
harshavardhana
requested changes
Jul 29, 2022
# Conflicts: # cmd/apierrorcode_string.go
klauspost
force-pushed
the
add-extended-checksum
branch
from
4617507
to
52eb945
Compare
klauspost
added a commit
to klauspost/minio-go
that referenced
this pull request
Aug 26, 2022
Single part, checksums must be done manually for now until we have trailing headers. For multipart we add CRC32C if we don't already send a checksum and we read the content before sending. Also serves as test for minio/minio#15433 - but should be backwards compatible. Needs to be tested against S3, only implemented from docs.
harshavardhana
approved these changes
Aug 29, 2022
Mint Automation
|
poornas
approved these changes
Aug 29, 2022
|
Unrelated to this PR on windows I have seen this occasional failure @klauspost would you be able to investigate? |
harshavardhana
pushed a commit
to minio/minio-go
that referenced
this pull request
Sep 16, 2022
Single part, checksums must be done manually for now until we have trailing headers. For multipart we add CRC32C if we don't already send a checksum and we read the content before sending. Also serves as test for minio/minio#15433 - but should be backwards compatible.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integrity checks https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html
For now only added to PutObject, and no trailing checksum support. Multipart requires more testing before it can be reliably enabled.
See #14885 for more information.
How to test this PR?
Send checksums as described in document above.
Tested through minio/minio-go#1690
Types of changes