Add support converting non-inlined to inlined #15444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
add-recreate
branch
2 times, most recently
from
677f2ee
to
7b45181
Compare
harshavardhana
changed the title
harshavardhana
force-pushed
the
add-recreate
branch
from
7b45181
to
c507d5a
Compare
harshavardhana
requested review from
vadmeste,
klauspost,
krisis,
kannappanr and
poornas
This is a feature to allow for inode compaction on large clusters that use a lot of small files spread across a large heirarchy.
harshavardhana
force-pushed
the
add-recreate
branch
from
c507d5a
to
1678fc7
Compare
Mint Automation
|
harshavardhana
commented
Aug 2, 2022
| @@ -560,6 +579,7 @@ func (er erasureObjects) healObject(ctx context.Context, bucket string, object s | |||
| }) | |||
| if len(inlineBuffers) > 0 && inlineBuffers[i] != nil { | |||
| partsMetadata[i].Data = inlineBuffers[i].Bytes() | |||
| partsMetadata[i].SetInlineData() | |||
There was a problem hiding this comment.
This a bug that is fixed to ensure that the partsMetadata contains the right set of headers to indicate after healing that this is an inlined data.
poornas
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support converting non-inlined to inlined
Motivation and Context
This is a feature to allow for inode compaction on
large clusters that use a lot of small files spread
across a large hierarchy.
How to test this PR?
minio/mc#4175 use this to
To migrate old objects that are not inlined to be
inlined with newer requirements.
Types of changes
Checklist:
commit-idorPR #here)