Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade golang-lint to the latest #15600

Merged
merged 1 commit into from
Aug 26, 2022
Merged

upgrade golang-lint to the latest #15600

merged 1 commit into from
Aug 26, 2022

Conversation

harshavardhana
Copy link
Member

Description

upgrade golang-lint to the latest

Motivation and Context

upgrading to go1.19

How to test this PR?

Nothing specific adds go1.19.x builds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation updated
  • Unit tests added/updated

vadmeste
vadmeste approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 433b6fa into minio:master Aug 26, 2022
@harshavardhana harshavardhana deleted the update-golang-lint branch August 26, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@poornas poornas poornas approved these changes

@aead aead Awaiting requested review from aead

@klauspost klauspost Awaiting requested review from klauspost

@kannappanr kannappanr Awaiting requested review from kannappanr

@krisis krisis Awaiting requested review from krisis

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshavardhana @vadmeste @poornas @bh4t