Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heal service accounts for LDAP users in site replication #15785

Merged
merged 1 commit into from Oct 4, 2022

Conversation

harshavardhana
Copy link
Member

Description

fix: heal service accounts for LDAP users in site replication

Motivation and Context

add healing for missing LDAP service accounts in
site replication.

How to test this PR?

You would need an LDAP setup to test this, please use https://github.com/minio/minio-iam-testing to configure LDAP based deployments.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana marked this pull request as ready for review October 3, 2022 22:32
@harshavardhana harshavardhana changed the title fix: heal service accounts for LDAP users in site replication [draft] fix: heal service accounts for LDAP users in site replication Oct 4, 2022
@harshavardhana
Copy link
Member Author

This PR is not finished yet.

add healing for missing LDAP service accounts in
site replication.
@harshavardhana harshavardhana changed the title [draft] fix: heal service accounts for LDAP users in site replication fix: heal service accounts for LDAP users in site replication Oct 4, 2022
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh more...

15785-2689fd3/mint-pools.sh.log:

Running with
SERVER_ENDPOINT:      minio-k8s2:31218
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0
RUN_ON_FAIL:          0

To get logs, run 'docker cp :/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 1 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... done in 43 seconds
(4/14) Running aws-sdk-ruby tests ... done in 5 seconds
(5/14) Running awscli tests ... done in 54 seconds
(6/14) Running healthcheck tests ... done in 0 seconds
(7/14) Running mc tests ... done in 22 seconds
(8/14) Running minio-go tests ... done in 1 minutes and 21 seconds
(9/14) Running minio-java tests ... FAILED in 35 seconds
{
  "name": "minio-java",
  "function": "getObjectRetention()",
  "duration": 54,
  "status": "FAIL",
  "error": "java.time.format.DateTimeParseException: Text '2022-10-07T07:01:45.4Z' could not be parsed at index 19 >>> [io.minio.Xml.unmarshal(Xml.java:55), io.minio.MinioAsyncClient.lambda$getObjectRetention$34(MinioAsyncClient.java:1699), java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642), java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506), java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073), io.minio.S3Base$1.onResponse(S3Base.java:559), okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519), java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128), java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628), java.base/java.lang.Thread.run(Thread.java:829)]"
}
(9/14) Running minio-js tests ... done in 1 minutes and 2 seconds
(10/14) Running minio-py tests ... done in 1 minutes and 29 seconds
(11/14) Running s3cmd tests ... done in 25 seconds
(12/14) Running s3select tests ... done in 4 seconds
(13/14) Running versioning tests ... done in 3 minutes and 6 seconds

Executed 13 out of 14 tests successfully.

Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 538aeef into minio:master Oct 4, 2022
@harshavardhana harshavardhana deleted the fix-iam branch October 4, 2022 17:44
@bh4t bh4t added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants