Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use admin request check for ReplicationDiff handler #15793

Merged
merged 2 commits into from Oct 5, 2022

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Oct 4, 2022

Description

Instead of the S3 request validation, use admin check. This is to avoid issues
when validating requests issued mc using madmin library.

Motivation and Context

Fix mc replicate diff command when the server has an explicite region

How to test this PR?

  1. Start two MinIO servers
  2. Enable site replication
  3. Create a bucket
  4. mc replicate diff /

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

instead of the S3 request validation.
@minio minio deleted a comment from minio-trusted Oct 4, 2022
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit 121f18a into minio:master Oct 5, 2022
@bh4t bh4t added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants