Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused getUpdateReaderFromFile function #15794

Merged
merged 1 commit into from Oct 5, 2022
Merged

Removing unused getUpdateReaderFromFile function #15794

merged 1 commit into from Oct 5, 2022

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Oct 5, 2022 •
edited

Signed-off-by: Lenin Alevski alevsk.8772@gmail.com

Description

Removing unused and potentially dangerous getUpdateReaderFromFile function

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@Alevsk
Removing unused getUpdateReaderFromFile function
2b3f375 
Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
@Alevsk Alevsk self-assigned this Oct 5, 2022
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

vadmeste
vadmeste approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it is unused but at least not documented, LGTM

@donatello donatello merged commit 4bdf41a into minio:master Oct 5, 2022
@Alevsk Alevsk deleted the remove-dead-code branch October 5, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@aead aead Awaiting requested review from aead

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@donatello donatello Awaiting requested review from donatello

Assignees

@Alevsk Alevsk

Labels
code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Alevsk @minio-trusted @vadmeste @harshavardhana @klauspost @donatello @bh4t