Encrypt checksums with KMS on CompleteMultipartUpload #16177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On KMS encryption, if checksums were provided on upload, they were not encrypted, resulting in the following error:
```
Error: sio: unexpected EOF (sio.Error)
5: d:\minio\minio\internal\logger\logger.go:258:logger.LogIf()
4: d:\minio\minio\cmd\encryption-v1.go:1095:cmd.(*ObjectInfo).decryptChecksums()
3: d:\minio\minio\cmd\object-handlers-common.go:319:cmd.setPutObjHeaders()
2: d:\minio\minio\cmd\object-multipart-handlers.go:687:cmd.objectAPIHandlers.CompleteMultipartUploadHandler()
1: net\http\server.go:2109:http.HandlerFunc.ServeHTTP()
```
Add encryption function to encrypt data properly.
vadmeste
reviewed
Dec 6, 2022
harshavardhana
approved these changes
Dec 6, 2022
harshavardhana
requested changes
Dec 6, 2022
So this is required for checksums. |
Mint Automation
|
harshavardhana
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With KMS encryption, if checksums were provided on upload, they were not encrypted, resulting in the following error:
Add encryption function to encrypt data properly.
How to test this PR?
Upload multipart with checksum to encrypted backend.
Types of changes