Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary logs for truncated XML inputs #16184

Merged

Conversation

harshavardhana
Copy link
Member

Description

remove unnecessary logs for truncated XML inputs

Motivation and Context

fewer logs! fixes specifically logs such as these

Dec 07 07:45:00 play minio[1433767]: API: PutObjectACL(bucket=test-5-12)                                                                                                                                           
Dec 07 07:45:00 play minio[1433767]: Time: 07:45:00 UTC 12/07/2022                                                                                                                                                 
Dec 07 07:45:00 play minio[1433767]: DeploymentID: f2b80bd5-02a4-455d-b268-b20fb3a1d93b                                                                                                                            
Dec 07 07:45:00 play minio[1433767]: RequestID: 172E7321C0C9940C                                                                                                                                                   
Dec 07 07:45:00 play minio[1433767]: RemoteHost: 103.252.50.208                                                                                                                                                    
Dec 07 07:45:00 play minio[1433767]: Host: play.minio.io                                                                                                                                                           
Dec 07 07:45:00 play minio[1433767]: UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Edg/107.0.1418.62                                  
Dec 07 07:45:00 play minio[1433767]: Error: EOF (*errors.errorString)                                                                                                                                              
Dec 07 07:45:00 play minio[1433767]:        5: internal/logger/logger.go:258:logger.LogIf()                                                                                                                        
Dec 07 07:45:00 play minio[1433767]:        4: cmd/api-errors.go:2211:cmd.toAPIErrorCode()                                                                                                                         
Dec 07 07:45:00 play minio[1433767]:        3: cmd/api-errors.go:2236:cmd.toAPIError()                                                                                                                             
Dec 07 07:45:00 play minio[1433767]:        2: cmd/acl-handlers.go:209:cmd.objectAPIHandlers.PutObjectACLHandler()                                                                                                 
Dec 07 07:45:00 play minio[1433767]:        1: net/http/server.go:2109:http.HandlerFunc.ServeHTTP()  

How to test this PR?

Not trivial

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 90d35b7 into minio:master Dec 7, 2022
@harshavardhana harshavardhana deleted the remove-unnecessary-logs branch December 7, 2022 16:30
@bh4t bh4t added the bugfix label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants