Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not rename multipart failed transactions back to tmp #16204

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

harshavardhana
Copy link
Member

Description

do not rename multipart failed transactions back to tmp

Motivation and Context

additionally, remove the limit of 5GiB of max
part size for each PutObjectPart().

How to test this PR?

Hard to test, however possible via changing manually
permission on the drive during PutObjectPart()

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member Author

This PR is a tiny subset of changes from #15781

additionally remove the limit of 5GiB of max
part size for each PutObjectPart().
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-erasure.sh ✔️
mint-dist-erasure.sh ✔️
mint-compress-encrypt-dist-erasure.sh ✔️
mint-pools.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fragile (which you confirmed) and complex.

@harshavardhana harshavardhana merged commit 444ff20 into minio:master Dec 12, 2022
@harshavardhana harshavardhana deleted the support-5ti branch December 12, 2022 09:40
@bh4t bh4t added the bugfix label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants