-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert '\' to '/' on windows #16852
Conversation
This is to ensure on windows we avoid arbitrary path escalation during PUT operations.
Mint Automation
|
@harshavardhana @kannappanr We should just reject objects with |
If we accept it, it will be a constant duality between |
The reason is we have seen keys with |
Yeah, that was my thought. Otherwise |
It won't get converted, it's only validated as a check to look for Sent a PR #16856 |
(cherry picked from commit 8d6558b)
Description
fix: convert '' to '/' on windows
Motivation and Context
This is to ensure on windows we avoid
arbitrary path escalation during PUT
operations.
How to test this PR?
Needs a windows machine to test
Types of changes
Checklist:
commit-id
orPR #
here)