commonParity should pick readable FileInfo #17032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Apr 14, 2023
vadmeste
approved these changes
Apr 14, 2023
harshavardhana
approved these changes
Apr 14, 2023
vadmeste
pushed a commit
to vadmeste/minio
that referenced
this pull request
Apr 18, 2023
vadmeste
pushed a commit
to vadmeste/minio
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
commonParitypicks parity of a maximally occurringFileInfo. In cases where twoFileInfocandidates occur, we should pick the one which has read quorum.Motivation and Context
commonParityin its current form would pick one or the otherFileInforandomly since it uses a map to calculate occurrence, which doesn't have a fixed ordering of keys.How to test this PR?
Unit test
Types of changes
Checklist:
commit-idorPR #here)