-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checksums from HTTP range request, add part checksums #17105
Merged
harshavardhana
merged 3 commits into
minio:master
from
klauspost:remove-checksums-partial
Apr 28, 2023
Merged
Remove checksums from HTTP range request, add part checksums #17105
harshavardhana
merged 3 commits into
minio:master
from
klauspost:remove-checksums-partial
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches AWS S3 behavior. This also removes it from part requests, but that will be added in a separate PR.
klauspost
changed the title
Remove checksums from HTTP range request
Remove checksums from HTTP range request, add part checksums
Apr 28, 2023
Testing part requests:
|
Checking range requests. Compare range vs non-range:
|
klauspost
added a commit
to klauspost/minio-go
that referenced
this pull request
Apr 28, 2023
* Tests range requests * Test multipart parts. Requires minio/minio#17105 to pass on MinIO. Passes on AWS.
harshavardhana
approved these changes
Apr 28, 2023
harshavardhana
pushed a commit
to minio/minio-go
that referenced
this pull request
May 3, 2023
* Tests range requests * Test multipart parts. Requires minio/minio#17105 to pass on MinIO. Passes on AWS.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Range requests silently ignores request for checksums. We now do so as well.
However part checksums should be stored and returned. This makes it possible for clients to compute expected checksums from parts.
This matches AWS S3 behavior.
We didn't store checksums, so this will only apply to new objects uploaded.
Motivation and Context
Compatibility
How to test this PR?
Mint tests here: minio/minio-go#1815
Types of changes