Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: veeam SOS API 'system.xml' strings #17202

Merged
merged 2 commits into from May 15, 2023
Merged

fix: veeam SOS API 'system.xml' strings #17202

merged 2 commits into from May 15, 2023

Conversation

harshavardhana
Copy link
Member

Description

fix: veeam SOS API 'system.xml' strings

Motivation and Context

fixes #17195

The system.xml should look like this:

    <?xml version="1.0" encoding="UTF-8"?>
    <SystemInfo>
      <ProtocolVersion>"1.0"</ProtocolVersion>
      <ModelName>"MinIO RELEASE.2023-04-28T18-11-17Z"</ModelName>
    </SystemInfo>

Original-Author: Omar Kohl omarkohl@posteo.net

We should keep the KBBlockSize value to 4MiB.

How to test this PR?

Needs Veeam SOS API support

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
fix: veeam SOS API 'system.xml' strings
af5b07b 
fixes minio#17195

The system.xml should look like this:

```
    <?xml version="1.0" encoding="UTF-8"?>
    <SystemInfo>
      <ProtocolVersion>"1.0"</ProtocolVersion>
      <ModelName>"MinIO RELEASE.2023-04-28T18-11-17Z"</ModelName>
    </SystemInfo>
```

Original-Author: Omar Kohl <omarkohl@posteo.net>

We should keep the KBBlockSize value to 4MiB.
@harshavardhana harshavardhana mentioned this pull request May 13, 2023
Closed
8 tasks
vadmeste
vadmeste requested changes May 13, 2023
View reviewed changes
cmd/veeam-sos-api.go Outdated Show resolved Hide resolved
harshavardhana
harshavardhana commented May 13, 2023
View reviewed changes
cmd/veeam-sos-api.go Outdated Show resolved Hide resolved
vadmeste
vadmeste approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit d063596 into minio:master May 15, 2023
16 checks passed
@harshavardhana harshavardhana deleted the fix-sos-api branch May 15, 2023 19:06
@bh4t bh4t added the bugfix label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@krisis krisis krisis approved these changes

@eco-minio eco-minio Awaiting requested review from eco-minio

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOS API (Veeam) system.xml is not compatible with Veeam
4 participants
@harshavardhana @vadmeste @krisis @bh4t