Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builtin policy entities command #17241

Merged
merged 1 commit into from
May 26, 2023
Merged

Update builtin policy entities command #17241

merged 1 commit into from
May 26, 2023

Conversation

donatello
Copy link
Member

Description

Previously this command returned LDAP user mappings in addition to any builtin user mappings. With this change, mc admin policy entities only returns buitin users/groups related mappings.

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@donatello
Update builtin policy entities command
58ef1ec 
Previously this command returned LDAP user mappings in addition to any
builtin user mappings. With this change, `mc admin policy entities` only
returns buitin users/groups related mappings.
@harshavardhana
Copy link
Member

Previously this command returned LDAP user mappings in addition to any builtin user mappings. With this change, mc admin policy entities only returns buitin users/groups related mapping

how else do we see ldap user/groups?

@donatello
Copy link
Member Author

how else do we see ldap user/groups?

With mc idp ldap policy entities

@donatello donatello merged commit 7a69c9c into minio:master May 26, 2023
16 checks passed
@donatello donatello deleted the policy-entities-ldap-fix branch May 26, 2023 05:31
@bh4t bh4t added the bugfix label May 31, 2023
@djwfyi djwfyi mentioned this pull request Jun 1, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas poornas approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@krisis krisis Awaiting requested review from krisis

@shtripat shtripat Awaiting requested review from shtripat

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donatello @harshavardhana @poornas @bh4t