Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return proper error if OIDC Discoverydoc fails to respond #17242

Merged
merged 2 commits into from
May 19, 2023
Merged

fix: return proper error if OIDC Discoverydoc fails to respond #17242

merged 2 commits into from
May 19, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented May 19, 2023 •
edited

Description

return err with status

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression issue17212
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

shtripat
shtripat reviewed May 19, 2023
View reviewed changes
docs/sts/web-identity.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from shtripat May 19, 2023 05:03
shtripat
shtripat approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana changed the title fix StatusCode not OK return nil fix: under openid return proper error if discoverydoc fails respond May 19, 2023
@harshavardhana harshavardhana changed the title fix: under openid return proper error if discoverydoc fails respond fix: return proper error if OIDC Discoverydoc fails to respond May 19, 2023
@harshavardhana harshavardhana merged commit e94e6ad into minio:master May 19, 2023
16 checks passed
@harshavardhana harshavardhana mentioned this pull request May 19, 2023
Closed
@jiuker jiuker deleted the return_error_with_status branch February 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiuker @harshavardhana @shtripat