Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid decommissioning DEL markers with single versions #17274

Merged
merged 1 commit into from
May 25, 2023

Conversation

harshavardhana
Copy link
Member

Description

avoid decommissioning DEL markers with single versions

Motivation and Context

ensure that we can decommission all versions including
null markers with other versions from the bucket.

How to test this PR?

Start locally with two pool setup

minio server /tmp/xl{1...4} /tmp/xl{5...8}

mc mb myminio/testbucket/

mc cp /etc/hosts myminio/testbucket/

mc version enable myminio/testbucket

mc cp /etc/hosts myminio/testbucket/

mc cp /etc/hosts myminio/testbucket/

mc cp /etc/hosts myminio/testbucket/

mc version suspend myminio/testbucket/

mc rm myminio/testbucket/hosts

mc ls --versions myminio/testbucket/
[2023-05-24 22:45:56 PDT]     0B STANDARD null v4 DEL hosts
[2023-05-24 22:45:50 PDT]   226B STANDARD 77a02c6b-1f02-4d98-8ee6-3eedd3d8f250 v3 PUT hosts
[2023-05-24 22:45:49 PDT]   226B STANDARD 3c7f4afe-dc42-41ec-8acd-3d3db423cef9 v2 PUT hosts
[2023-05-24 22:45:49 PDT]   226B STANDARD ba405e3f-3d3e-4ba8-bfaf-f41f2bda87f5 v1 PUT hosts

mc admin decom start /tmp/xl{5...8}

Once the decom starts, it must finish and the final result after the pool removal must be

[2023-05-24 22:45:56 PDT]     0B STANDARD null v4 DEL hosts
[2023-05-24 22:45:50 PDT]   226B STANDARD 77a02c6b-1f02-4d98-8ee6-3eedd3d8f250 v3 PUT hosts
[2023-05-24 22:45:49 PDT]   226B STANDARD 3c7f4afe-dc42-41ec-8acd-3d3db423cef9 v2 PUT hosts
[2023-05-24 22:45:49 PDT]   226B STANDARD ba405e3f-3d3e-4ba8-bfaf-f41f2bda87f5 v1 PUT hosts

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

also ensure that we can decommission all versions including
`null` markers with other versions from the bucket.
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 9b5829c into minio:master May 25, 2023
16 checks passed
@harshavardhana harshavardhana deleted the decom branch May 25, 2023 16:18
@bh4t bh4t added the bugfix label May 31, 2023
@ravindk89
Copy link
Contributor

@harshavardhana our original Decomm PR had this already - is this a pure bug fix only?

donatello pushed a commit to donatello/minio that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants