s3: Add x-minio-error-code header for S3 HEAD requests #17283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
May 25, 2023
For HeadObject and HeadBucket, it is hard to understand the reason of a 403 response since the HEAD request does not return a response body. This PR will add a header which contains the error code that will be sent if this was a GET and not a HEAD request. e.g.: AccessDenied, SignatureDoesNotMatch, InvalidAccessKeyId
klauspost
approved these changes
May 26, 2023
harshavardhana
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For HeadObject and HeadBucket, it is hard to understand the reason
of a 403 response since the HEAD request does not return a response body.
This PR will add a header which contains the error code that will be
sent if this was a GET and not a HEAD request.
e.g.: AccessDenied, SignatureDoesNotMatch, InvalidAccessKeyId
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)