Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication: use latest object info for metrics update #17333

Merged
merged 1 commit into from Jun 2, 2023
Merged

replication: use latest object info for metrics update #17333

merged 1 commit into from Jun 2, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Jun 1, 2023

When there is a lot of MRF backlog being concurrently processed on the same object version, the previous replication status gathered while queuing the task could get stale because a previous replication attempt already succeeded while this task was waiting its turn.

Use the latest replication metadata from reader as previous status to avoid over counting replicated size.

Description

Motivation and Context

Correctness

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@poornas
replication: use latest object info for metrics update
a9c3871 
When there is a lot of MRF backlog being concurrently processed on
the same object version, the previous replication status gathered
while queuing the task could get stale because a previous
replication attempt already succeeded while this task was waiting
its turn.

Use the latest replication metadata from reader as previous status
to avoid over counting replicated size.
kannappanr
kannappanr approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit e95825a into minio:master Jun 2, 2023
17 checks passed
@harshavardhana harshavardhana deleted the fxmetrics branch June 2, 2023 01:52
@bh4t bh4t added the bugfix label Jun 6, 2023
vadmeste pushed a commit to vadmeste/minio that referenced this pull request Jul 13, 2023
@poornas @harshavardhana
replication: use latest object info for metrics update (minio#17333)
f7f12ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
bugfix priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poornas @harshavardhana @kannappanr @bh4t