-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement batch expiration for permanent deletes of expired objects #17792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-batch
branch
from
August 4, 2023 19:38
3994e57
to
720cbea
Compare
krisis
reviewed
Aug 4, 2023
poornas
requested changes
Aug 4, 2023
harshavardhana
force-pushed
the
fix-batch
branch
2 times, most recently
from
August 4, 2023 22:52
a40b91d
to
bd0ee65
Compare
harshavardhana
changed the title
Implement batch expiration for targeted ILM
Implement batch expiration for permanent deletes of expired objects
Aug 4, 2023
harshavardhana
force-pushed
the
fix-batch
branch
2 times, most recently
from
August 5, 2023 04:04
b8cc6c7
to
d64f740
Compare
harshavardhana
force-pushed
the
fix-batch
branch
from
August 5, 2023 15:31
d64f740
to
b404146
Compare
krisis
reviewed
Aug 7, 2023
} | ||
rnd := rand.New(rand.NewSource(time.Now().UnixNano())) | ||
|
||
skip := func(info FileInfo) (ok bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
skip := func(info FileInfo) (ok bool) { | |
filter := func(info FileInfo) (ok bool) { |
opts.WalkFitler
takes a function which returns true if the entry should be returned as part of the Walk calls results. skip
gives the opposite impression/idea. This is a minor change but will help future readers understand the intent better.
8 tasks
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Aug 29, 2023
Based on an initial PR from Harshavardhana - minio#17792
11 tasks
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Aug 29, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Aug 30, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Sep 1, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Sep 6, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Sep 6, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Oct 13, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Oct 16, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Oct 20, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Oct 23, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 1, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 2, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 7, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 9, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 14, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 15, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 16, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 17, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 20, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 23, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 28, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Nov 30, 2023
Based on an initial PR from Harshavardhana - minio#17792
krisis
pushed a commit
to krisis/minio
that referenced
this pull request
Dec 2, 2023
Based on an initial PR from Harshavardhana - minio#17792
harshavardhana
pushed a commit
that referenced
this pull request
Dec 2, 2023
Based on an initial PR from - #17792 But fully completes it with newer finalized YAML spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement batch expiration for permanent deletes of expired objects
Motivation and Context
How to test this PR?
You would need two PRs
Types of changes
Checklist:
commit-id
orPR #
here)