Improve ListObject Compatibility #18099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not error out when a provided marker is before or after the prefix, but instead just ignore it if before and return an empty list when after. Fixes minio#18093 (mint may have to be adjusted for this, waiting for results)
harshavardhana
approved these changes
Sep 25, 2023
Jamstah
added a commit
to Jamstah/distribution
that referenced
this pull request
Oct 17, 2023
This fixes some of the tests for minio. The walk tests needs a version of minio that contains minio/minio#18099 The storage classes minio supports are a subset of the s3 classes. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not error out when a provided marker is before or after the prefix, but instead just ignore it if before and return an empty list when after.
Fixes #18093
How to test this PR?
In-repo tests adjusted.
mint may have to be adjusted for this, waiting for resultsMint also ok.Types of changes