support proxying of tagging requests in replication #18649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornas
force-pushed
the
proxytagging
branch
3 times, most recently
from
e68d0cb
to
e77c61b
Compare
harshavardhana
approved these changes
Dec 14, 2023
harshavardhana
requested changes
Dec 14, 2023
|
PTAL at the conflicts @poornas |
poornas
force-pushed
the
proxytagging
branch
2 times, most recently
from
147aa06
to
d518faa
Compare
poornas
changed the title
Note: even if proxying is successful, PutObjectTagging/DeleteObjectTagging will continue to report a 404 since the object is not present locally.
harshavardhana
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
Intended for active-active replication setup with peers under a GLB - where upload goes to one site and tagging request is received on this object on a peer before replication has a chance to complete.
How to test this PR?
site replication setup for A <-> B
upload a very large file on A, and send tagging request to B before replication completes on B.
Note: tag replication will be proxied to A, the
tag setrequest on B will return 200 as Return code with an extra headerX-Minio-Tagging-Proxiedto indicate tagging was proxied to peer.In case there are more than one replication targets - proxying will return 200 OK, even if one tag operation succeeded.
Types of changes
Checklist:
commit-idorPR #here)