Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export tier metrics #18678

Merged
merged 1 commit into from Dec 21, 2023
Merged

Export tier metrics #18678

merged 1 commit into from Dec 21, 2023

Conversation

krisis
Copy link
Member

@krisis krisis commented Dec 19, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

  • minio_node_tier_ttlb_seconds_distribution - Distribution of time to last byte for streaming objects from warm tier
  • minio_node_tier_requests_success - Number of requests to download object from warm tier that were successful
  • minio_node_tier_requests_failure - Number of requests to download object from warm tier that failed

Motivation and Context

Observability into remote tier performance

How to test this PR?

Sample output

./mc admin prometheus metrics myminio/ node | grep tier
# HELP minio_node_tier_requests_failure Number of requests to download object from warm tier that failed
# TYPE minio_node_tier_requests_failure counter
minio_node_tier_requests_failure{server="minio3:9000",tier="WARM-1"} 0
# HELP minio_node_tier_requests_success Number of requests to download object from warm tier that were successful
# TYPE minio_node_tier_requests_success counter
minio_node_tier_requests_success{server="minio3:9000",tier="WARM-1"} 1
# HELP minio_node_tier_ttlb_seconds_distribution Distribution of time to last byte for streaming objects from warm tier
# TYPE minio_node_tier_ttlb_seconds_distribution gauge
minio_node_tier_ttlb_seconds_distribution{le="0.010",server="minio3:9000",tier="WARM-1"} 0
minio_node_tier_ttlb_seconds_distribution{le="0.100",server="minio3:9000",tier="WARM-1"} 1
minio_node_tier_ttlb_seconds_distribution{le="1.000",server="minio3:9000",tier="WARM-1"} 1
minio_node_tier_ttlb_seconds_distribution{le="10.000",server="minio3:9000",tier="WARM-1"} 1
minio_node_tier_ttlb_seconds_distribution{le="2.000",server="minio3:9000",tier="WARM-1"} 1
minio_node_tier_ttlb_seconds_distribution{le="5.000",server="minio3:9000",tier="WARM-1"} 1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@krisis krisis force-pushed the tier-ttlb branch 2 times, most recently from 98487cf to 3ffeb75 Compare December 19, 2023 23:54
@krisis krisis marked this pull request as ready for review December 19, 2023 23:54
cmd/tier.go Outdated Show resolved Hide resolved
cmd/tier.go Show resolved Hide resolved
minio_node_tier_ttlb_seconds - Distribution of time to last byte for streaming objects from warm tier
minio_node_tier_requests_success - Number of requests to download object from warm tier that were successful
minio_node_tier_requests_failure - Number of requests to download object from warm tier that failed
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 56b7045 into minio:master Dec 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants