allow pre-allocating buffers to reduce frequent GCs during growth #18686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
pre-allocate
branch
from
cc3849f
to
e821b9d
Compare
|
Usually garbage collecting is the expensive part. But pre-allocating will make it seem more "stable" in terms of memory usage, so that is a reasonable bonus. Maybe keep 1024 buffers for SNSD? |
klauspost
reviewed
Dec 20, 2023
klauspost
reviewed
Dec 20, 2023
harshavardhana
force-pushed
the
pre-allocate
branch
3 times, most recently
from
a511a9f
to
2c8c38c
Compare
This PR also increase per node bpool memory from 1024 entries to 2048 entries, along with that it also moves byte pool centrally instead of being per pool.
harshavardhana
force-pushed
the
pre-allocate
branch
from
2c8c38c
to
d933873
Compare
harshavardhana
force-pushed
the
pre-allocate
branch
from
399c854
to
88df145
Compare
harshavardhana
changed the title
moting9
pushed a commit
to moting9/minio
that referenced
this pull request
Dec 25, 2023
…nio#18686) This PR also increases per node bpool memory from 1024 entries to 2048 entries; along with that, it also moves the byte pool centrally instead of being per pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
allow pre-allocating buffers to reduce frequent GCs during growth
Motivation and Context
This PR also increases per node bpool memory from 1024 entries
to 2048 entries; along with that, it also moves the byte pool
centrally instead of being per pool.
How to test this PR?
Nothing special this is not enabled by default
Types of changes
Checklist:
commit-idorPR #here)