tier: Allow edit of the new Azure and AWS auth params #18690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow edit for the service principal credentials fro Azure and the web identity token for AWS; Also add more validation of input parameters in the code.
harshavardhana
approved these changes
Dec 21, 2023
vadmeste
changed the title
krisis
reviewed
Dec 21, 2023
krisis
approved these changes
Dec 21, 2023
moting9
pushed a commit
to moting9/minio
that referenced
this pull request
Dec 25, 2023
Allow editing for the service principal credentials from Azure and the web identity token for AWS; Also, more validation of input parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Allow edit for the service principal credentials fro Azure and the web identity token for AWS;
Also add more validation of input parameters in the code.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)