Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject clients that do not send proper payload #18701

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Dec 22, 2023

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: reject clients that do not send a proper payload

Motivation and Context

nodes trying to connect to hosts that do not
trust them must reject with 403's

Currently, there are places where we keep the connection
active and mux server has to reject the connection with
a deadline later.

How to test this PR?

Start with a three-node setup and then expand with 2nd pool by adding 4th node but with the same three hosts from the previous pool with a new drive.

Please don't restart the first pool nodes, only start the second pool. Leads to random
errors showing up in the logs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit da55499 into minio:master Dec 22, 2023
19 checks passed
@harshavardhana harshavardhana deleted the websocket branch December 22, 2023 09:26
moting9 pushed a commit to moting9/minio that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants