Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-info: Avoid initializing audit/log http/kafka targets #18703

Merged
merged 1 commit into from Dec 22, 2023

Conversation

vadmeste
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

This can cause unnecessary ServerInfo() call delay.

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

This can cause unnecessary ServerInfo() call delay.
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows to retain the ability to reconnect during an Info() call. Of course we should do this only once via sync.Once()

internal/logger/targets.go Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 8bd4f65 into minio:master Dec 22, 2023
19 checks passed
moting9 pushed a commit to moting9/minio that referenced this pull request Dec 25, 2023
…8703)

This can cause unnecessary ServerInfo() call delay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants