Fix precendence bug in S3Select SQL IN clauses #18708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a precendence issue in SQL Select where `a in b and c = 3` was parsed as `a in (b and c = 3)`. Fixes minio#18682
donatello
force-pushed
the
fix-select-sql
branch
from
f5690fb
to
e6320ee
Compare
harshavardhana
approved these changes
Dec 22, 2023
harshavardhana
approved these changes
Dec 23, 2023
moting9
pushed a commit
to moting9/minio
that referenced
this pull request
Dec 25, 2023
Fixes a precendence issue in SQL Select where `a in b and c = 3` was parsed as `a in (b and c = 3)`. Fixes minio#18682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a precendence issue in SQL Select where
a in b and c = 3was parsed asa in (b and c = 3).Fixes #18682
Motivation and Context
How to test this PR?
Tests included.
Types of changes
Checklist:
commit-idorPR #here)