Make enableSha256 configurable in mc perf test #18712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Make enableSha256 configurable in mc perf test
Motivation and Context
To make user to run mc perf test with or without enable-sha256-payload flag. The original value is hardcode as false in MinIO. Now we make it configurable by user and keep the default value as false.
How to test this PR?
This PR depends on integration of madmin-go and mc PR
minio/madmin-go#257
minio/mc#4802
old version mc:
./mc support perf object myminio/ --dev --airgap -v // no sha256 takes high cpu usage in server side, X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
new version mc
/mc support perf object myminio/ --dev --airgap -v // no sha256 takes high cpu usage in server side, X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
./mc support perf object myminio/ --dev --airgap -v --enable-sha256-payload // sha256 takes high cpu usage in server side, X-Amz-Content-Sha256: STREAMING-AWS4-HMAC-SHA256-PAYLOAD
./mc support perf object myminio/ --dev --airgap -v --enable-sha256-payload=true // sha256 takes high cpu usage in server side, X-Amz-Content-Sha256: STREAMING-AWS4-HMAC-SHA256-PAYLOAD
./mc support perf object myminio/ --dev --airgap -v --enable-sha256-payload=false // no sha256 takes high cpu usage in server side, X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
Types of changes
Checklist:
commit-id
orPR #
here)