Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all older unused APIs #18769

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jan 10, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

remove all older unused APIs

Motivation and Context

just house keeping

How to test this PR?

CI/CD should do the work

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

cmd/storage-rest-client.go Show resolved Hide resolved
@klauspost
Copy link
Contributor

This mint failure seems persistent... could also be related:

{
  "name": "minio-js",
  "function": "\"after all\" hook in \"functional tests\"",
  "duration": 7,
  "status": "FAIL",
  "error": "S3Error: The specified bucket does not exist at parseError (minio-js/src/internal/xml-parser.ts:26:13) at Object.parseResponseError (minio-js/src/internal/xml-parser.ts:75:11) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Client.makeRequestStreamAsync (minio-js/src/internal/client.ts:629:19) at Client.makeRequestAsyncOmit (minio-js/src/internal/client.ts:550:17) at Client.removeBucket (minio-js/src/internal/client.ts:796:5)"
}

@harshavardhana
Copy link
Member Author

#18775 (comment) @klauspost happening with other PRs as well.

@harshavardhana
Copy link
Member Author

Now that the HealBucket() regression is fixed the no such bucket error has vanished.

@harshavardhana harshavardhana merged commit 21d60ea into minio:master Jan 18, 2024
19 checks passed
@harshavardhana harshavardhana deleted the move-to-websockets branch January 18, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants