avoid disk monitoring leaks under various conditions #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
avoid-leaks
branch
from
3742803
to
79c703a
Compare
harshavardhana
force-pushed
the
avoid-leaks
branch
from
79c703a
to
519b1ca
Compare
- HealFormat() was leaking healthcheck goroutines for disks, we are only interested in enabling healthcheck for the newly formatted disk not for existing disks. - When disk is a root-disk a random disk monitor was leaking while we ignored the drive. - When loading the disk for each erasure sets we were leaking goroutines for the prepare-storage.go disks which were replaced via the globalLocalDrives slice - avoid disk monitoring utilizing health tokens that would cause exhaustion in the tokens, prematurely which were meant for incoming I/O. This is ensured by avoiding to write O_DIRECT aligned buffer instead write 2048 worth of content only as O_DSYNC which is sufficient.
harshavardhana
force-pushed
the
avoid-leaks
branch
from
519b1ca
to
db02660
Compare
kobalicek
reviewed
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
avoid disk monitoring leaks under various conditions
Motivation and Context
HealFormat() was leaking health check goroutines for disks; we are only
interested in enabling health checks for the newly formatted disk,
not existing disks.
When the disk is a root disk, a random disk monitor leaks while we
ignore the drive.
When loading the disk for each erasure set, we were leaking goroutines
for the
prepare-storage.godisks, which were replaced via the globalLocalDrivesslice
Avoid disk monitoring utilizing health tokens that would prematurely cause
exhaustion in the tokens, which were meant for incoming I/O. This is ensured
by avoiding writing O_DIRECT aligned buffer; instead, writing 2048 worth of
content only as O_DSYNC, which is sufficient.
How to test this PR?
Hard to test but you need xfs_freeze to simulate the overall behavior
Types of changes
Checklist:
commit-idorPR #here)