Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): add support to set the display name of OpenID provider #18781

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

lentidas
Copy link
Contributor

Description

This PR just adds a small quality of life feature to the OIDC configuration in the Helm chart, allowing the user to set the display name of the OIDC provider.

Motivation and Context

See above.

How to test this PR?

I've tested the modification by simply deploying the chart.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana harshavardhana merged commit 2c38e44 into minio:master Jan 24, 2024
@lentidas
Copy link
Contributor Author

@harshavardhana thank you for the approval and merge 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants