site replication: remove extraneous log for missing group

[poornas]

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Motivation and Context

Avoid non actionable log where group is present on a site without members. This cannot be synced to peer - user action should be to fix this by deleting the group.

API:SRPeerReplicateIAMItem()
Time:03:43:20 UTC 01/14/2024
Level:ERROR
DeploymentID:776afbbe-023f-33da-66e2-88cd1fb44b28
Host:GVA-P-MIOAP-103-storage:9000
RemoteHost:10.41.116.118
UserAgent:MinIO (linux; amd64) madmin-go/2.0.0
Error:Specified group does not exist (cmd.SRError)
Backtrace:
1:
internal/logger/logger.go:258:logger.LogIf()
2:
cmd/admin-handlers-site-replication.go:188:cmd.adminAPIHandlers.SRPeerReplicateIAMItem()
3:
net/http/server.go:2136:http.HandlerFunc.ServeHTTP()

How to test this PR?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Optimization (provides speedup with no functional changes)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Fixes a regression (If yes, please add commit-id or PR # here)
• Unit tests added/updated
• Internal documentation updated
• Create a documentation update request here

[donatello]

Looks like no such group error will be propagated instead of being silenced now?

[harshavardhana]

Looks like no such group error will be propagated instead of being silenced now?

HTTP calls don't provide order guarantees here, so failing here oddly for things like group does not exist is not useful. We should generally convert this into idempotent behavior.